chore(build-fix1): release 0.4.0 #640
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @el-virt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request represents an automated major version release, advancing the sdk, cli, and web-app components to version 0.4.0. The changes primarily involve updating version numbers across various configuration files and incorporating the comprehensive list of new features and bug fixes into the changelogs for each module.
Highlights
- Automated Release: This pull request is an automated release, bumping the versions of the
sdk,cli, andweb-appmodules to0.4.0. - Changelog Updates: New changelog entries for version
0.4.0have been added to the respectiveCHANGELOG.mdfiles for each module, detailing numerous new features and bug fixes. - Dependency Management: The
package.jsonandpackage-lock.jsonfiles for each module have been updated to reflect the new0.4.0versions, ensuring consistent dependency management.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
el-virt
force-pushed
the
release-please--branches--build-fix1
branch
from
01baf15 to
3c5df2a
Compare
There was a problem hiding this comment.
Code Review
This pull request automates the release of version 0.4.0 for the sdk, cli, and web-app packages. The changes primarily involve version bumps in package.json and package-lock.json files, updates to the release-please-manifest.json, and the generation of CHANGELOG.md files.
There are critical concerns regarding the baseline versions and inter-package dependencies that need to be addressed before this release can proceed:
-
Previous Version Mismatch: For all three packages (
lib/sdk,cli,web-app), thepackage.jsonandpackage-lock.jsonfiles indicate they are being updated from version0.3.2. However, the PR description and therelease-please-manifest.jsonstate that the update is from version0.3.3. This discrepancy suggests that the current branch might be based on an outdated state (pre-0.3.3) for these packages. This could lead to an incorrect release, potentially missing changes fromv0.3.3. Please verify and ensure the release is built upon the correctv0.3.3baseline for all packages. -
Outdated SDK Dependencies: The
cliandweb-apppackages'package.jsonfiles (and consequently theirpackage-lock.jsonfiles) still depend on an older version of@opentdf/sdk(specificallyfile:../lib/opentdf-sdk-0.3.2.tgz). Since@opentdf/sdkis being released as0.4.0in this same PR, these dependencies must be updated to point to the new0.4.0version of the SDK (e.g.,file:../lib/opentdf-sdk-0.4.0.tgzor the equivalent, assuming the tgz filename includes the version). Releasingcliandweb-appwith dependencies on an old SDK version would be a significant issue. (Note: The lines declaring these dependencies are not part of the diffs in this PR, so specific line comments cannot be made here, but this is a critical aspect for the release's correctness.)
Additionally, there's a minor consistency issue:
- The file
.github/release-please/release-please-manifest.jsonis missing a trailing newline, while other JSON files in the project appear to follow this convention.
Please investigate these points to ensure a robust and correct release.
| { | ||
| "name": "@opentdf/ctl", | ||
| "version": "0.3.2", | ||
| "version": "0.4.0", |
There was a problem hiding this comment.
The version in this package-lock.json is being bumped from 0.3.2 to 0.4.0 (also on line 9). However, the PR description and the release-please-manifest.json indicate that the cli package's previous version was 0.3.3. This discrepancy suggests the release might be based on an outdated commit for the cli package. Please verify the baseline for this release to ensure it correctly builds upon v0.3.3.
| { | ||
| "name": "@opentdf/ctl", | ||
| "version": "0.3.2", | ||
| "version": "0.4.0", |
There was a problem hiding this comment.
The version is being updated from 0.3.2 to 0.4.0. However, the PR description and release-please-manifest.json suggest the previous version for the cli package was 0.3.3. This indicates a potential issue with the baseline commit for this release. It's crucial to ensure this release is correctly based on v0.3.3.
lib/package-lock.json
Outdated
| { | ||
| "name": "@opentdf/sdk", | ||
| "version": "0.3.2", | ||
| "version": "0.4.0", |
There was a problem hiding this comment.
This package-lock.json shows the version for @opentdf/sdk changing from 0.3.2 to 0.4.0 (also on line 9). According to the PR description and release-please-manifest.json, the previous version was 0.3.3. This suggests the release might be based on an incorrect (outdated) commit for the lib (sdk) package. Please verify the baseline.
| { | ||
| "name": "@opentdf/sdk", | ||
| "version": "0.3.2", | ||
| "version": "0.4.0", |
There was a problem hiding this comment.
The version for @opentdf/sdk is being updated from 0.3.2 to 0.4.0. The PR description and release-please-manifest.json indicate the previous version was 0.3.3. This discrepancy points to a potential issue with the baseline commit for this SDK release. Please ensure this release correctly builds upon v0.3.3.
| { | ||
| "name": "web-app", | ||
| "version": "0.3.2", | ||
| "version": "0.4.0", |
There was a problem hiding this comment.
The version in this package-lock.json for web-app is changing from 0.3.2 to 0.4.0 (also on line 9). The PR description and release-please-manifest.json state the previous version was 0.3.3. This suggests the release might be based on an outdated commit for the web-app package. Please verify the baseline.
| { | ||
| "name": "web-app", | ||
| "version": "0.3.2", | ||
| "version": "0.4.0", |
There was a problem hiding this comment.
The web-app version is being updated from 0.3.2 to 0.4.0. However, the PR description and release-please-manifest.json indicate the previous version was 0.3.3. This suggests a potential issue with the baseline commit for this release. Please ensure this release is correctly based on v0.3.3.
| "lib": "0.4.0", | ||
| "cli": "0.4.0", | ||
| "web-app": "0.4.0" | ||
| } |
There was a problem hiding this comment.
This JSON file is missing a trailing newline. Other JSON files in the project (e.g., package.json files) appear to use trailing newlines. For consistency and to avoid potential issues with some tools or noisy diffs when lines are added later, it's recommended to add a trailing newline.
}
3c5df2a to
0c6f8c9
Compare
el-virt
changed the title
el-virt
force-pushed
the
release-please--branches--build-fix1
branch
2 times, most recently
from
6de6518 to
85c8cd2
Compare
el-virt
force-pushed
the
release-please--branches--build-fix1
branch
from
85c8cd2 to
2a47a46
Compare
el-virt
force-pushed
the
release-please--branches--build-fix1
branch
from
2a47a46 to
8f87245
Compare
|
🤖 I have created a release beep boop
0.4.0 (2025-06-20)
Features
--policyBinding ecdsaoption (#352) (4e54c0d)Bug Fixes
This PR was generated with Release Please. See documentation.